[Bug 428725] Review Request: wiggle - help apply patches when 'patch' can't

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wiggle - help apply patches when 'patch' can't


https://bugzilla.redhat.com/show_bug.cgi?id=428725





------- Additional Comments From tibbs at math.uh.edu  2008-01-14 19:45 EST -------
A few comments:

The URL given in the spec is 403 (no permission) for me.

The package fails to build:

nroff -man wiggle.1 > wiggle.man
/bin/sh: nroff: command not found
make: *** [wiggle.man] Error 127
make: *** Waiting for unfinished jobs....
error: Bad exit status from /var/tmp/rpm-tmp.44906 (%build)

Looks like you need BuildRequires: groff

The package seems to have a test suite; it should be called in a %check section.
 Unfortunately it looks like the makefile calls it as part of the build process,
but you could just call the wiggle and wiggle.man targets manually.

The package doesn't build with the proper compiler flags, because the makefile
tkes the ill-advised step of overriding CFLAGS.  That will need to be patched
out or worked around so the compiler is called with $RPM_OPT_FLAGS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.