[Bug 226324] Merge Review: psutils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: psutils


https://bugzilla.redhat.com/show_bug.cgi?id=226324


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
               Flag|                            |needinfo?(mbacovsk at redhat.co
                   |                            |m)




------- Additional Comments From panemade at gmail.com  2008-01-15 03:53 EST -------
1) use macros. replace /usr/bin with %{_bindir}and /usr/lib with %{_libdir}
2)you can even write defattr as defattr(-,root,root,-)
3)buildroot is wrong make it similar to given at
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
4)rpmlint gave me
psutils.i386: E: tag-not-utf8 %changelog
psutils.i386: W: invalid-license distributable
psutils.i386: W: no-url-tag
psutils.i386: E: only-non-binary-in-usr-lib
psutils.src: E: non-utf8-spec-file
/tmp/psutils-1.17-27.fc9.src.rpm.4019/psutils.spec
psutils.src:48: E: hardcoded-library-path in /usr/lib/psutils
psutils.src:141: W: macro-in-%changelog attr
psutils.src: E: tag-not-utf8 %changelog
psutils.src: W: invalid-license distributable
psutils.src: W: no-url-tag


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.