[Bug 428567] Review Request: ETL-devel - Extended Template Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ETL-devel - Extended Template Library


https://bugzilla.redhat.com/show_bug.cgi?id=428567





------- Additional Comments From kwizart at gmail.com  2008-01-15 07:32 EST -------
* You need to download the sources with wget -N in order to prevent timestamps
changes
-rw-rw-r-- 1 builder builder 335182 jan 11 16:37 ETL-0.04.10.tar.gz
instead of 
-rw-rw-r-- 1 builder builder 335182 oct 10 04:37 ETL-0.04.10.tar.gz

* if the package name is ETL-devel, the spec file have to be ETL-devel.spec

* License is GPLv2+ - good

* The package do not seems to be arch independent but only because it has ETL.pc
in /usr/lib64 on lib64 system - seems strange

* you need to use: make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-rw-r--r-- 1 builder builder   1249 jan 15 12:39 value
instead of
-rw-r--r-- 1 builder builder   1249 mar 16  2007 value

* etl_profile.h is a config.h kind of file. usually it shouldn't be installed.
same as etl_config.h - If upstream claims they are really needed, then it might
be interesting to keep a timestamps reference from a file to avoid multiarches
conflict (but only if they are the same on i386 and x86_64, and also ppc and
ppc64 at least). Might be safe to remove ETL-config then. (and to patch
dependant apps to use pkg-config if needed).
see http://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks

* The package bundle no library - as such it is not needed to have
/sbin/ldconfig in post and postun.

* pkg-config file: ETL.pc - it Requires only
But includedir remains includedir=/usr/include instead of
includedir=/usr/include/ETL as such they is a need to check if headers of
dependent packages have ETL/spline or only spline (for example). Might need to
test package that links against it... specially if others libs are missing.

* As the package isn't marked as noarch (might evaluate if it could be with a
tweak for pkg-config) a debuginfo is generated. If the package remains arch
dependant, we might consider to use %define debug_package %{nil}. If the package
could be noarch, then it might need to work on x86 x86_64 ppc ppc64 (and maybe
others arch). then no debuginfo package will be created.





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.