[Bug 427185] Review Request: okteta - Binary editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: okteta - Binary editor


https://bugzilla.redhat.com/show_bug.cgi?id=427185





------- Additional Comments From michel.sylvan at gmail.com  2008-01-15 12:27 EST -------
Almost done -- one question about desktop-file-utils, and another about macros.
Also, on a system without KDE4 installed, the application menu does not show any
icon (khexedit icon is not on the system), and the application itself does not
have any icons (presumably because oxygen theme is not installed).

MUST

Passed:
• rpmlint
• package name
• spec file name
• package guideline-compliant
• license complies with guidelines
• license field accurate
• license file not deleted
• spec in US English
• spec legible
• source matches upstream
• builds under >= 1 archs, others excluded
• build dependencies complete
• locales handled using %find_lang, no %{_datadir}/locale
• library -> ldconfig
• own all directories
• no dupes in %files
• permission
• %clean RPM_BUILD_ROOT
• Package contains code
• clean buildroot before install
• filenames UTF-8

N/A:
• large docs => -doc
• doc not runtime dependent
• headers in -devel
• static in -static
• if contains *.pc, req pkgconfig
• if libfiles are suffixed, the non-suffixed goes to devel
• devel requires versioned base package

Unknown:
• macros used consistently
Question: are those _kde4_* macros going to be present for the foreseeable future?

FAILED:
• desktop file uses desktop-file-install



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.