[Bug 427669] Review Request: gnome-nds-thumbnailer - Thumbnailer for Nintendo DS ROM files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-nds-thumbnailer - Thumbnailer for Nintendo DS ROM files


https://bugzilla.redhat.com/show_bug.cgi?id=427669





------- Additional Comments From jbowes at redhat.com  2008-01-15 17:19 EST -------
Hi Erik, thanks for taking a look

Updated:
Spec URL: http://jbowes.fedorapeople.org/tmp/gnome-nds-thumbnailer.spec
SRPM URL:
http://jbowes.fedorapeople.org/tmp/gnome-nds-thumbnailer-1.0.2-2.fc8.src.rpm


(In reply to comment #1)
> Conclusion:
> 
> - License tag needs to be changed to GPLv2+
> - BuildRequires: GConf2 needs to be added

I've updated these.

> - $RPM_BUILD_ROOT needs to be changed to %{buildroot}

IIRC, the guidelines state that neither is better than the other, so long as one
is used consistantly, so i've left it as RPM_BUILD_ROOT.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.