[Bug 428823] Review Request: sectool - A security audit system and intrusion detection system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sectool - A security audit system and intrusion detection system


https://bugzilla.redhat.com/show_bug.cgi?id=428823





------- Additional Comments From mitr at redhat.com  2008-01-15 18:00 EST -------
* The source0: URL does not point to the tarball, the real URL is
https://hosted.fedoraproject.org/sectool/attachment/wiki/WikiStart/sectool-0.1.0.tar.bz2?format=raw
  Perhaps use only "%{name}-%{version}.tar.bz2" and put the full URL in a
  comment.
FIXME: source0: content in this case
* The uploaded tarball does not match the tarball in src.rpm!!
* License: GPL+ is probably correct, but do you _want_ it to be GPL+?
  (RH copyright guidelines say something else)
* ExclusiveOS: useless, just drop it
* Two source0 lines!
* sectool-gui should probably Requires: sectool = %{version}-%{release}
* Requires: gtk2 - You probably want pygtk2.
* desktop file: "HardwareSettings" isn't true
* Drop the (cat %{name}.lang)
* Add "%doc README:
* Use one of the recommended BuildRoot: values
* sectool.desktop should be shipped in sectool-gui
* sectool.desktop: Remove .png from Icon=
* Add --vendor=fedora to desktop-file-install
* A %defattr directive is missing in %files gui

* URL: perhaps use https://hosted.fedoraproject.org/sectool/wiki/WikiStart to
  avoid a certificate mismatch warning
* Consider using macros for paths; at least you can
  (make PREFIX=%{_prefix} ...and so on for other variables),
  perhaps add more variables to the Makefile to remove other hard-coded
  directory paths like /etc, /usr/bin and /var/lib/sectool and /usr/share
* Can you use (make %{?_smp_mflags}) ?
* %description: s/inerface/interface
* %description gui: To me this reads like "sectool provides a GUI";
  perhaps just "sectool-gui provides a GTK-based graphical user interface to
  sectool."?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.