[Bug 333491] Review Request: preload - Preload is an adaptive readahead daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: preload - Preload is an adaptive readahead daemon


https://bugzilla.redhat.com/show_bug.cgi?id=333491


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: preload-0.4 |Review Request: preload -
                   |- Preload is an adaptive    |Preload is an adaptive
                   |readahead daemon            |readahead daemon
               Flag|                            |fedora-review?




------- Additional Comments From kevin at tummy.com  2008-01-15 23:59 EST -------
a few issues: 

1. You don't seem to be applying all the patches, just patch0? 
Any reason for that? 

2. You seem to have <script> in a few places, where it should be the name of the
init script (preload).

3. You have a macro in your changelog. You need to escape it with %% there to
prevent rpm from expanding it. 

4. I am seeing it set to on by default in the init script. 
You would need to patch the preload.init.in file to prevent that... 

In particular the 
# chkconfig: 2345 05 95
and
# Default-Start:     2 3 4 5
lines. 

Can you fix up those things? 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.