[Bug 426867] Review Request: scala - Hybrid functional/object-oriented language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scala - Hybrid functional/object-oriented language


https://bugzilla.redhat.com/show_bug.cgi?id=426867





------- Additional Comments From geoff at programmer-monk.net  2008-01-16 02:33 EST -------
(In reply to comment #12)
> A-1: Description stage:
> * Disttag
>   - Please consider to use %?_dist tag.
>     http://fedoraproject.org/wiki/Packaging/DistTag

I had not read that page before. Now I understand why the dist tag is useful.  I
will post a new revision with the dist tag.

> ? Some questions for Requires
>   - For vim-scala, is it sufficient to require only vim-common?

I am guessing that you wonder this because vim-common does not provide
/usr/share/vim/vimfiles/{ftdetect,indent,syntax}. I will file a bug against the
vim package because I think vim-common should own these directories. Another
package (vim-vimoutliner) also installs to
/usr/share/vim/vimfiles/{colors,ftdetect,ftplugin,syntax} so until vim-common
provides these directories I request a variance for installing files into these
un-owned directories. 

>   - For XXX-scala subpackages (like emacs-scala), don' they need
>     scala package?

Those packages are mainly addons to various editors to provide syntax
highlighting for scala files. They do not actually call to scala in any way
(with the exception of the emacs mode, but this is an optional feature).  It
seems useful to allow syntax highlighting without having scala installed.

> A-2: %prep, %build, %install stage
> * Timestamps
>   http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
>   - When using "cp" or "install" commands, please add "-p" option
>     to keep timestamps.

Will address in new revision

> A-3: %files
> * Directory ownership issue
>   - There are many directories which are not owned by any
>     packages.

I think the new revision should fix these

> * gtksourceview2-scala
>   - For what purpose does this subpackage exist? This subpackage
>     contains no files.

I made a silly mistake.  I will fix this in the new revision.

> B. rpmlint

My new package should fix most of these, if not all.

I have also decided not to package the source codes in scala-devel so I will
rename it to ant-scala since all it will be is the classpath file to allow the
use of scala from ant.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.