[Bug 244234] Review Request: R-maanova - Analysis of N-dye Micro Array using mixed model effect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-maanova - Analysis of N-dye Micro Array using mixed model effect


https://bugzilla.redhat.com/show_bug.cgi?id=244234


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-16 13:15 EST -------
Cool, this builds and rpmlint is clean (except for the usual R warnings which
I'll ignore).

* source files match upstream:
   ba7362507468f1f5c758cebc142119bc9c358f8286e788b12b982ee3f1f0af4d  
   maanova_1.9.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK (I didn't check the French versions)
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has only the usual R complaints.
* final provides and requires are sane:
   maanova.so()(64bit)
   R-maanova = 1.9.0-1.fc9
  =
   /bin/sh
   R
   R-qvalue
   libR.so()(64bit)
   libRblas.so()(64bit)
   libRlapack.so()(64bit)
   libgcc_s.so.1()(64bit)
   libgfortran.so.1()(64bit)

* %check is present and all tests pass.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R package registration)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.