[Bug 428576] Review Request: mkelfimage - Utility to create ELF boot images from Linux kernel images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mkelfimage - Utility to create ELF boot images from Linux kernel images


https://bugzilla.redhat.com/show_bug.cgi?id=428576


matt_domsch at dell.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matt_domsch at dell.com
             Status|NEW                         |NEEDINFO
               Flag|                            |fedora-review+,
                   |                            |needinfo?(tibbs at math.uh.edu)




------- Additional Comments From matt_domsch at dell.com  2008-01-17 00:40 EST -------
* rpmlint completely empty OK
* Name OK
* SPEC file name matches package name OK
* Packaging
  - Legal GPLv2 OK
  - no pre-built binaries OK
  - FHS dirs OK
  - changelog OK
  - tags OK
  - BuildRoot OK, could be better
  - prepping buildroot OK
  - no Requires OK
  - no PreReq ok
  - Summary & description OK
  - Encoding UTF-8 OK
  - no non-ascii filenames OK
  - %docs OK
  - compiler flags passed by %configure w/o changes, OK
  - debuginfo created OK
  - no static libs OK
  - no duplication of system libs OK
  - no rpaths OK
  - no config files OK
  - no initscripts OK
  - no desktop files OK
  - macros sane OK
  - no locale files OK
  - no file copying OK
  - parallel make OK
  - no scriptlets OK
  - no conditional deps OK
  - builds as another user OK
  - not relocatable OK
  - code, not content.  OK
  - dirs owned by filesystem pkg OK
  - no user and groups created OK
  - not a web app OK
  - no conflicts OK
  - no external kernel modules OK
* License GPLv2 OK
* License field matches OK
* License COPYING included in %doc OK
* Spec in English OK
* Spec legible OK
* source matches upstream tarball OK
* package compiles on i386 at least OK
* no extra BuildRequires OK
* no locales OK
* no shared libs OK
* not relocatable OK
* dir ownership OK
* no dupe files OK
* permissions on files OK, defaddr present OK
* %clean OK
* use of macros OK
* code, not content OK
* no large docs OK
* no headers OK
* no static libs OK
* no pkgconfig OK
* no lib files OK
* no devel package needed OK
* no .la files OK
* no GUI apps, therefore no .desktop file OK
* directory ownership OK
* %install cleans out first OK
* all filesnames in UTF-8 OK

SHOULD
* license included OK
* not translated, OK
* builds in mock for i386 and x86_64
* did not run it - SHOULD DO - leave up to LTSP dev / test team
* no scriptlets OK
* no subpackages OK
* no pkgconfig files OK
* no file deps OK


Nits:
* license is GPLv2 per manpage, remove comment in spec at checkin.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.