[Bug 427479] Review Request: perl-ParseLex - Perl lexical analyzer.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ParseLex - Perl lexical analyzer.


https://bugzilla.redhat.com/show_bug.cgi?id=427479





------- Additional Comments From jfearn at redhat.com  2008-01-17 17:40 EST -------
(In reply to comment #9)
> I'll do a full review....
> 
> Builds OK for me.  rpmlint is down to just
>   perl-ParseLex.noarch: E: useless-explicit-provides perl(Parse::Token)
> I see where you added the filter, but I think you neglected to change
something on the sed line.
> 
> What you need is:
>   cat << \EOF > ParseLex-prov
>   #!/bin/sh
>   %{__perl_provides} $* |\
>     sed -e '/perl(Parse::Token)$/d'
>   EOF
> Note the change from "unwanted_provides" to "Parse::Token", but also note that
I've anchored the match to the end of the string so the proper versioned provide
doesn't get removed as well.

Fixed.

> I notice that the tarball included in the srpm is not the same as the tarball
on CPAN.  Do you know what's going on there?  Upstream source hasn't changed in
nine years but the tarball in the srpm has a modification time of the 15th.

As per #6 the Changes file was converted to UTF8 and test 4 was tweaked for
newer test modules.

These two changes + ParseLex-2.15-syntax.patch need to be pushed upstream, time
limitations are the only reason they haven't been.

> If you are going to use macros like %{__make}, you should consistently use
macros.  Which means %{__rm} in %clean and %{__cat}, %{__sed}, %{__chmod} in
%prep. (There's no macro for find for whatever reason.)  Or you can just drop
the macros.  It's up to your personal preference, but you must be consistent.

Consistorised ... if it's not a word it should be :)

> The Summary: is a bit content-free (it's just the name turned around with
module appended).  Upstream says "Generator of lexical analyzers" which at least
says something about what it does.

Updated.

http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-ParseLex.spec
http://svn.fedorahosted.org/svn/documentation-devel/trunk/Files/perl-ParseLex-2.15-10.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.