[Bug 429037] Review Request: isns-utils - Daemon and tools for iSNS management.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: isns-utils - Daemon and tools for iSNS management.


https://bugzilla.redhat.com/show_bug.cgi?id=429037





------- Additional Comments From mchristi at redhat.com  2008-01-17 18:44 EST -------
(In reply to comment #2)
> Honestly I have no idea what iSNS is, and looking at this package doesn't
> help.  Would it be too much to add a line of explanation to your %description?
> Maybe
>   The Internet Storage Name Service (iSNS) protocol allows automated
>   discovery, management and configuration of iSCSI and Fibre Channel devices
>   (using iFCP gateways) on a TCP/IP network.
> ?

That is a lot better. Done.

> 
> I do not believe that the license of this package is GPLv2.  COPYING includes
> the LGPL, the source files do not include any license headers at all and
> README says LGPLv2+.  I believe the latter is correct.

You are right.

> 
>   isns-utils.x86_64: W: file-not-utf8 /usr/share/doc/isns-utils-0.0/COPYING
> You do need to pass this through iconv; the copyright symbols in the document
> not valid utf8.

Ah ok thanks. Fixed.

> 
> The other rpmlint complaints are OK.


Ok thanks for the review. Here is the updated spec and src rpm:

http://people.redhat.com/mchristi/iscsi/FC9/open-isns/v2/isns-utils.spec
http://people.redhat.com/mchristi/iscsi/FC9/open-isns/v2/isns-utils-0.0-1.20070927snap.fc7.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.