[Bug 188542] Review Request: hylafax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





------- Additional Comments From faxguy at howardsilvan.com  2008-01-18 14:46 EST -------
  hylafax.src: W: invalid-license BSD-like
Just "BSD" is good enough for me.

  hylafax.x86_64: W: incoherent-version-in-changelog 5.1.11-1 5.1.11-2.fc9
Okay... I'll try to remember to add a changelog for each release even though the
spec file isn't changing materially.

  hylafax.x86_64: W: file-not-utf8 /usr/share/doc/hylafax-5.1.11/CONTRIBUTORS
Fixed upstream.

  hylafax.x86_64: W: non-conffile-in-etc /etc/hylafax/faxcover_example_sgi.ps
HylaFAX uses a configurable cover page template file, and this is an
example/sample one.  The configurable cover page template file *does* belong in
the configuration directory, /etc/hylafax.  So I believe that the samples do
belong there as well.  Can we say that the warning doesn't apply here?

  hylafax.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/hylafax
Okay, this is changed/fixed now.

  hylafax.x86_64: E: explicit-lib-dependency libtiff
Okay, I've (again) removed libtiff.  (I've had RPM builders, SuSE I think, who
wanted it there.)

  hylafax.x86_64: E: script-without-shebang /usr/sbin/faxsetup.linux
This is fixed upstream.

  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/ro
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/pt_BR
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/fr
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/pl
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/pt
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/de
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/es
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/en
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/tr
  hylafax.x86_64: E: script-without-shebang /var/spool/hylafax/bin/dict/it
This is all fixed upstream.

Okay, please now see:

SPEC: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax.spec
SRPM: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax-5.2.2-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.