[Bug 248679] Review Request: R-hgu95av2probe - Probe sequence data for microarrays of type hgu95av2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-hgu95av2probe - Probe sequence data for microarrays of type hgu95av2


https://bugzilla.redhat.com/show_bug.cgi?id=248679


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-18 16:42 EST -------
This package is smaller than the recent genome packages, but it's another one
where you might consider dropping the dist tag and sharing one copy between all
releases.

* source files match upstream:
   44729a9f9b1bc87e6ae6a2978d85f75d2f63628dd8042d08c38617559b0c2940  
   hgu95av2probe_2.0.0.tar.gz
* package meets naming and versioning guidelines (not that the name actually 
   means anything to me, but it reflects the name of the tarball)
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint has only the usual R complaints.
* final provides and requires are sane:
   R-hgu95av2probe = 2.0.0-1.fc9
  =
   /bin/sh
   R
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R package registration)
* acceptable content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.