[Bug 426413] Review Request: metacafe-dl - Command-line program to download videos from metacafe.com

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 19 19:41:25 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: metacafe-dl - Command-line program to download videos from metacafe.com


https://bugzilla.redhat.com/show_bug.cgi?id=426413





------- Additional Comments From wolfy at nobugconsulting.ro  2008-01-19 14:41 EST -------
I suggest to take a look at the review (and mostly at the recommendations
available over there) of youtube-dl.

Two short observations regarding your spec:
- The original "package" does not include a license as a separate file;
according to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-90d644ce2c5db60bad3ba8773fe11653c7629dc3
neither are you allowed to include the license as a separate file
- According to http://fedoraproject.org/wiki/Packaging/NamingGuidelines your
version and release tags are not correct. I suggest to ditch the "0" you have
used as version and replace it with 2007.10.09; start with 1 as release tag
(which can further be incremented, should the package need modifications but
within the same version). 
- As %doc you could use a copy of the page from
http://www.arrakis.es/~rggi3/metacafe-dl/



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list