[Bug 422841] Review Request: python-libgmail-docs - Documents and examples for python-libgmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-libgmail-docs - Documents and examples for python-libgmail


https://bugzilla.redhat.com/show_bug.cgi?id=422841


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-19 23:03 EST -------
Review:
+ package builds in mock (rawhide i386).
- rpmlint is NOT silent for SRPM and for RPM.
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/gcp.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/sendmsg.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/unreadmsgcount.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/test_fwd_attach.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/readmail.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/gmailpopd.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/test_notifier.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/gmailftpd.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/gmailsmtp.py
python-libgmail-docs.noarch: W: spurious-executable-perm
/usr/share/doc/python-libgmail-0.1.8/examples/archive.py
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/archive.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/gcp.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/gmailftpd.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/gmailpopd.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/gmailsmtp.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/readmail.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/sendmsg.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/test_fwd_attach.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/test_notifier.py /usr/bin/env
python-libgmail-docs.noarch: W: doc-file-dependency
/usr/share/doc/python-libgmail-0.1.8/examples/unreadmsgcount.py /usr/bin/env
+ source files match upstream url
d8a209a6fcb6b7560977070fe4eaaf6f libgmail-docs_0.3.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage does exist.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.

rpmlint output though does not look good but that is ok to accept here for this
package as per commented by ville in Comment#3.

APPROVED.

Ville,
   If you think some more things should be done here. please comment here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.