[Bug 241597] Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-Tidy - (X)HTML validation in a Perl object
Alias: perl-HTML-Tidy

https://bugzilla.redhat.com/show_bug.cgi?id=241597


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From ruben at rubenkerkhof.com  2008-01-20 08:38 EST -------
Hi Chris,

The package looks good to me, the only thing is that the webtidy script needs a dependency on 
LWP::Simple.

Checklist:
* source matches upstream:
   7912a2a739c6e2cfb6b409fb30b5047e18285dad  HTML-Tidy-1.08.tar.gz
* package is properly named according to the naming guidelines
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds fine in mock
* package installs properly
* rpmlint has no complaints.
* final provides and requires are sane:
[ruben at odin SPECS]$ rpm -q --provides perl-HTML-Tidy
Tidy.so  
perl(HTML::Tidy) = 1.08
perl(HTML::Tidy::Message)  
perl-HTML-Tidy = 1.08-2.fc8
[ruben at odin SPECS]$ rpm -q --requires perl-HTML-Tidy
/usr/bin/perl  
libc.so.6  
libc.so.6(GLIBC_2.1.3)  
libtidy-0.99.so.0  
perl >= 0:5.006001
perl(:MODULE_COMPAT_5.8.8)  
perl(Carp)  
perl(Getopt::Long)  
perl(HTML::Tidy)  
perl(HTML::Tidy::Message)  
perl(XSLoader)  
perl(base)  
perl(constant)  
perl(strict)  
perl(warnings)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rtld(GNU_HASH)  
* %check is present and succeeds
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* documentation is small, so no -doc subpackage is necessary.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.