[Bug 429007] Review Request: python-cherrypy2 - A pythonic, object-oriented web development framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cherrypy2 - A pythonic, object-oriented web development framework


https://bugzilla.redhat.com/show_bug.cgi?id=429007


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-20 19:25 EST -------
Not much to say, really.

* source files match upstream:
   a41e1b31ab723f50223b303991bb4e1a420a05deb2f4ab923a2ceadece4854cf  
   CherryPy-2.3.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   python-cherrypy2 = 2.3.0-3.fc9
  =
   python(abi) = 2.5
   python-setuptools

* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Egg stuff:
* All files built from source.
* No dependencies downloaded.
* egg-info included.
* easy_install -m used properly for a compat package.
* I'll assume that when the new version of cherrypy is included, it will be the 
  default version.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.