[Bug 251805] Review Request: postgresql-orafce - Implementation of some Oracle functions into PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-orafce - Implementation of some Oracle functions into PostgreSQL


https://bugzilla.redhat.com/show_bug.cgi?id=251805


devrim at commandprompt.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW
               Flag|needinfo?(devrim at commandprom|
                   |pt.com)                     |




------- Additional Comments From devrim at commandprompt.com  2008-01-20 19:58 EST -------
Hi,

(In reply to comment #1)
 
> - You should post the results of rpmlint command.


 
> - You should apply the common compiler flags defined as $RPM_OPT_FLAGS or
> %{optflags} .

Added.
 
> - You should use -p option with 'install' command to preserve timestamps.

Added.

> - You should improve Makefile to enable to build with non-privilleged user.
> See the attachment. "make install" tries to make a directory of
> "/usr/share/pgsql/contrib", and %buildroot is not used.
> I could not build your package because of this problem.

Ok, asked upstream for a solution for this.

> - In addition, "/usr/share/pgsql/contrib" should be owned this package, if you
> intend to create the directory actually. It is not owned by the postgresql
> package.

Done.

Thanks for the review. Will submit the new SRPM after upstream comes with a fix
for the problem you reported.

Regards, Devrim


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.