[Bug 427480] Review Request: perl-XML-TreeBuilder - Perl parser that builds XML trees

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-TreeBuilder - Perl parser that builds XML trees


https://bugzilla.redhat.com/show_bug.cgi?id=427480


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-20 22:21 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
49e04fb6ba12b1414cb490e7f0c712a9  XML-TreeBuilder-3.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/00about....ok
t/10main.....ok
All tests successful.
Files=2, Tests=6,  0 wallclock secs ( 0.12 cusr +  0.01 csys =  0.13 CPU)
+ Package perl-XML-TreeBuilder-3.09-9.fc9 ->
  Provides: perl(XML::Element) = 3.09 perl(XML::TreeBuilder) = 3.09
  Requires: perl >= 1:5 perl(Carp) perl(HTML::Element) perl(HTML::Element) >=
3.08 perl(HTML::Tagset) perl(HTML::Tagset) perl(XML::Element) perl(XML::Parser)
perl(XML::Parser) perl(strict) perl(vars)
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.