[Bug 428566] Review Request: gnome-build - GNOME build framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-build - GNOME build framework


https://bugzilla.redhat.com/show_bug.cgi?id=428566


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-01-21 12:18 EST -------
(In reply to comment #1)
 
> I find that the Spec file
> contains:
> 
> Provides:       perl(GBF::Make)
> 
> [...]
> 
> cat << \EOF > %{name}-prov
> #!/bin/sh
> %{__perl_provides} $* |\
>  sed -e '/perl(Make)/d' \
>      -e '/perl(Make::Target)/d' \
>      -e '/perl(Make::Rule::Vars)/d' \
>      -e '/perl(Make::Rule)/d'
> EOF
> 
> %define __perl_provides %{_builddir}/%{name}-%{version}/%{name}-prov
> chmod +x %{__perl_provides}
> 
> cat << \EOF > %{name}-req
> #!/bin/sh
> %{__perl_requires} $* |\
>  sed -e '/perl(Make)/d' \
>      -e '/perl(Make::Target)/d' \
>      -e '/perl(Make::Rule::Vars)/d' \
>      -e '/perl(Make::Rule)/d'
> EOF
> 
> %define __perl_requires %{_builddir}/%{name}-%{version}/%{name}-req
> chmod +x %{__perl_requires}
> 
> However, in the %files section does not put anything in
> /usr/lib/perl5. So what is the use of these lines?


Well, actually
---------------------------------------------------------------------------------
[tasaka1 at localhost ~]$ `rpm --eval %__perl_provides` /usr/share/gnome-build/GBF/*.pm
perl(GBF::AmFiles)
perl(GBF::General)
perl(Make) = 1.00
perl(Make::Rule)
perl(Make::Rule::Vars)
perl(Make::Target)
----------------------------------------------------------------------------------

and perl(MakeXXXX) is unwilling. Also:
----------------------------------------------------------------------------------
[tasaka1 at localhost ~]$ `rpm --eval %__perl_requires` /usr/bin/gbf-mkfile-parse 
perl(GBF::General)
perl(GBF::Make)
perl(strict)
----------------------------------------------------------------------------------
This contains 'perl(GBF::Make)'.

I will review this later. By the way I would appreciate it if you
would review my review request (bug 429443)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.