[Bug 225608] Merge Review: basesystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: basesystem


https://bugzilla.redhat.com/show_bug.cgi?id=225608





------- Additional Comments From pertusus at free.fr  2008-01-21 18:24 EST -------
I still think that in the %description, the following is not useful
(and it is wrong, though for weird corner cases):

 Basesystem should be in every installation of a system, and it
 should never be removed.

This is not a blocker though.

Another suggestion would be to remove Fedora from the Summary
and %description, there is nothing fedora specific here.

The summary isn't that good in my opinion. Maybe something along:
Summary: Skeleton package which sets up a simple system

And last I think a comment in the spec would be nice, like

# this package is Required by the libc and so should almost always be
# installed, and its only use is to have the needed Requires(Pre)

So
* rpmlint ignorable
basesystem.src: E: no-cleaning-of-buildroot %install
basesystem.src: E: no-cleaning-of-buildroot %clean

You can clean those errors if you want to, be it only for the sake
of having consistent packaging.

basesystem.src: W: no-url-tag
basesystem.noarch: W: no-documentation
basesystem.noarch: W: no-url-tag
* there is nothing built, no file

Please consider fixing my comments, but they are not blockers.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.