[Bug 428115] Review Request: perl-WWW-Search - Virtual base class for WWW searches

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-WWW-Search - Virtual base class for WWW searches


https://bugzilla.redhat.com/show_bug.cgi?id=428115


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-22 00:00 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6508b06a8b71e14b9e03e4d9f1b38cff  WWW-Search-2.496.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=136,  3 wallclock secs ( 1.84 cusr +  0.16 csys =  2.00 CPU)
+ Package perl-WWW-Search-2.496-3.fc9 ->
  Provides: perl(WWW::Search) = 2.551 perl(WWW::Search::Null)
perl(WWW::Search::Null::Count) = 1.15 perl(WWW::Search::Null::Empty) = 1.9
perl(WWW::Search::Null::Error) = 1.11 perl(WWW::Search::Null::NoVersion)
perl(WWW::Search::Result) = 1.5 perl(WWW::Search::Simple)
perl(WWW::Search::Test) = 2.278 perl(WWW::SearchResult) = 2.74
  Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(CGI) perl(Carp)
perl(Config) perl(Cwd) perl(Data::Dumper) perl(Date::Manip) perl(Exporter)
perl(File::Copy) perl(File::Find) perl(File::Path) perl(File::Spec::Functions)
perl(Getopt::Long) perl(HTML::TreeBuilder) perl(HTTP::Cookies)
perl(HTTP::Request) perl(HTTP::Response) perl(HTTP::Status)
perl(LWP::MemberMixin) perl(LWP::RobotUA) perl(LWP::UserAgent) perl(POSIX)
perl(Pod::Usage) perl(Test::More) perl(URI) perl(URI::Escape) perl(WWW::Search)
perl(WWW::Search::Result) perl(WWW::SearchResult) perl(base) perl(constant)
perl(strict) perl(vars) perl(warnings)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.