[Bug 429703] Review Request: xenner - Xen emulator for kvm

Tue Jan 22 18:27:09 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xenner - Xen emulator for kvm

https://bugzilla.redhat.com/show_bug.cgi?id=429703

berrange at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(kraxel at redhat.com)

------- Additional Comments From berrange at redhat.com  2008-01-22 13:27 EST -------
MUST: rpmlint must be run on every package.

 $ rpmlint  xenner-0.22-1.fc9.src.rpm
 $ rpmlint  xenner-0.22-1.fc9.x86_64.rpm
 xenner.x86_64: W: spurious-executable-perm /usr/share/doc/xenner-0.22/vivm

 Just a convenient example script - ignore warning.

 OK

MUST: The package must be named according to the Package Naming Guidelines.

 OK

MUST: The spec file name must match the base package %{name}

 OK

MUST: The package must meet the Packaging Guidelines.

 OK

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.

 OK

MUST: The License field in the package spec file must match the actual license.

 OK

MUST: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

 OK

MUST: The spec file must be written in American English.

 OK

MUST: The spec file for the package MUST be legible.

 OK

MUST: The sources used to build the package must match the upstream source

  $ md5sum  xenner-0.22.tar.gz 
  d4fee3cbdc7e6102e13a0316742f22ab  xenner-0.22.tar.gz

 OK

MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.

 OK  x86_64 rawhide

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in ExcludeArch.

 FAIL

  Needs to have:

    ExclusiveArch: i386 i686 x86_64

  Since it depends on Xen, which only builds on those archs

MUST: All build dependencies must be listed in BuildRequires

 OK

MUST: The spec file MUST handle locales properly

 OK

MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.

 OK

MUST: If the package is designed to be relocatable, the packager must state this
fact in the request for review

 N/A

MUST: A package must own all directories that it creates.

 FAIL

 Should use

   %dir %{_libdir}/xenner
   %{_libdir}/xenner/*

MUST: A package must not contain any duplicate files in the %files listing.

  OK

MUST: Permissions on files must be set properly.

  OK

MUST: Each package must have a %clean section

  OK

MUST: Each package must consistently use macros

  OK

MUST: The package must contain code, or permissable content

  OK

MUST: Large documentation files should go in a -doc subpackage

  OK

MUST: If a package includes something as %doc, it must not affect the runtime of
the application

  OK

MUST: Header files must be in a -devel package.

  N/A

MUST: Static libraries must be in a -static package.

  N/A

MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'

  N/A

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.

  N/A

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency

  N/A

MUST: Packages must NOT contain any .la libtool archives

  OK

MUST: Packages containing GUI applications must include a %{name}.desktop file

  N/A

MUST: Packages must not own files or directories already owned by other packages

  OK

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}

  OK

MUST: All filenames in rpm packages must be valid UTF-8.

  OK

SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

  N/A

SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.

  OK

SHOULD: The reviewer should test that the package builds in mock.

  OK  fedora x86_64 rawhide

SHOULD: The package should compile and build into binary rpms on all supported
architectures.

  OK  x86_64 + i6868

SHOULD: The reviewer should test that the package functions as described.

  Not tested

SHOULD: If scriptlets are used, those scriptlets must be sane.

  FAIL.

  The chkconfig script %preun need to be wrapped  in a conditional to handle
upgrades/downgrades correctly

  if [ $1 = 0 ]; then
    /sbin/chkconfig --del xenner
  fi

SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.

  N/A

SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this
is usually for development purposes, so should be placed in a -devel pkg.

  N/A

SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.

  N/A

In summary, need to fix:

  - ExclusiveArch
  - %dir in files list
  - %preun script

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.