[Bug 429550] Review Request: openoffice.org-voikko - Finnish spellchecker and hyphenator extension for OpenOffice.org

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openoffice.org-voikko - Finnish spellchecker and hyphenator extension for OpenOffice.org


https://bugzilla.redhat.com/show_bug.cgi?id=429550





------- Additional Comments From caolanm at redhat.com  2008-01-23 03:17 EST -------
- MUST: rpmlint must be run on every package. The output should be posted in the
review.
rpmlint ../RPMS/i386/openoffice.org-voikko-2.1-0.2.fc9.i386.rpm
<no output>
rpmlint ../SRPMS/openoffice.org-voikko-2.1-0.2.fc9.src.rpm
<no output>

- MUST: The package must be named according to the Package Naming Guidelines.
*check*

- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on  Package Naming Guidelines.
*check* (I assume that the f7-f8 one will have the spec renamed on import)

- MUST: The package must meet the  Packaging Guidelines.
*check*

- MUST: The package must be licensed with a Fedora approved license and meet the
 Licensing Guidelines.
*check*

- MUST: The License field in the package spec file must match the actual license.
*check*

- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
*check*

- MUST: The spec file must be written in American English.
*check*

- MUST: The spec file for the package MUST be legible
*check*

- MUST: The sources used to build the package must match the upstream source
*check*

- MUST: The package must successfully compile and build
*check*
- MUST: If the package does not successfully compile, build or work on an
architecture...
*check*

MUST: All build dependencies must be listed in BuildRequires
*check*

- MUST: The spec file MUST handle locales properly.
*check*

- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig...
*check*

- MUST: If the package is designed to be relocatable...
*check*

- MUST: A package must own all directories that it creates...
*check*

- MUST: A package must not contain any duplicate files in the %files listing.
*check*

- MUST: Permissions on files must be set properly
*check*

- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
*check*

- MUST: Each package must consistently use macros..
*check*

- MUST: The package must contain code, or ...
*check*

- MUST: Large documentation files should go in a -doc subpackage
*check*
- MUST: If a package includes something as %doc...
*check*

- MUST: Header files must be in a -devel package.
*check*

- MUST: Static libraries must be in a -static package.
*check*

- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
*check*

- MUST: If a package contains library files with a suffix
*check*

- MUST: In the vast majority of cases, devel packages...
*check*

- MUST: Packages must NOT contain any .la libtool archives...
*check*

- MUST: Packages containing GUI applications must include a %{name}.desktop...
*check*

- MUST: Packages must not own files or directories already owned by other packages.
*check*

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)
*check*

- MUST: All filenames in rpm packages must be valid UTF-8.
*check*


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.