[Bug 226353] Merge Review: quota

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: quota


https://bugzilla.redhat.com/show_bug.cgi?id=226353


limb at jcomserv.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From limb at jcomserv.net  2008-01-23 08:43 EST -------
rpmlint:

Uses BuiltPreReq.  Not allowed under current policy, not sure what the
workaround is.

Macro in changelog, change %attr to %%attr in lines 281 and 311.

Summary ends with dot.  Remove it.

Patch3 is applied in an ifarch block, this is OK.

Should /usr/include/rpcsvc/rquota.h be in a -devel package?

Other blockers:

License tag should be BSD, GPLv2+.

Replace:
Source0:
http://unc.dl.sourceforge.net/sourceforge/linuxquota/quota-%{version}.tar.gz
with:
Source0: http://downloads.sourceforge.net/linuxquota/%{name}-%{version}.tar.gz

Otherwise, it looks OK.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.