[Bug 428642] Review Request: remctl - GSSAPI secured remote command execution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: remctl - GSSAPI secured remote command execution


https://bugzilla.redhat.com/show_bug.cgi?id=428642


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-01-23 09:20 EST -------
For 2.11-2:

* rpmlint issues:
-------------------------------------------------------------------
[tasaka1 at localhost remctl]$ rpmlint remctl remctl-devel remctl-perl
remctl.i386: E: library-without-ldconfig-postin /usr/lib/libremctl.so.1.0.1
remctl.i386: E: library-without-ldconfig-postun /usr/lib/libremctl.so.1.0.1
remctl.i386: W: unused-direct-shlib-dependency /usr/lib/libremctl.so.1.0.1
/usr/lib/libkrb5.so.3
remctl.i386: W: unused-direct-shlib-dependency /usr/lib/libremctl.so.1.0.1
/usr/lib/libk5crypto.so.3
remctl.i386: W: unused-direct-shlib-dependency /usr/lib/libremctl.so.1.0.1
/lib/libcom_err.so.2
remctl-perl.i386: E: non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Net/Remctl/Remctl.so
0555
-------------------------------------------------------------------
  Summary:
  - /sbin/ldconfig mustt be run on %post, %postun in remtcl package.
  - The permission of Remctl.so must be 0755, not 0555
    ! Please fix the permission by using "chmod" in %install, not
      by using %attr(...).

* manfiles
  - Files under %_mandir are automatically marked as %doc.

* Timestamps
  - To keep timestamps, I recommend to use
--------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
--------------------------------------------------------------------
    This usually works for recent autotool-based Makefiles.

* Undesirably owned directories
--------------------------------------------------------------------
%files perl
%{perl_vendorarch}/*
--------------------------------------------------------------------
  - This is not allowed because the directory %perl_vendorarch/auto is 
    already owned by perl.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.