[Bug 429221] Review Request: dzcomm - Dzcomm a RS-232 API/lib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dzcomm - Dzcomm a RS-232 API/lib


https://bugzilla.redhat.com/show_bug.cgi?id=429221


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-01-23 10:47 EST -------
! Note
  For general packaging guidelines you can refer to
  http://fedoraproject.org/wiki/Packaging/Guidelines
  http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

I just did a quick glance at your spec file and just tried to rebuild
your srpm.

* Rebuild failed.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=362863
  It seems that at least texinfo is missing from BuildRequires.
* Fix SourceURL (see "Sourceforge.net" of
  http://fedoraproject.org/wiki/Packaging/SourceURL )
* Don't use Epoch unless needed.
* BuildRoot does not match Fedora guidelines.
* Please make it sure that fedora specific compilation flags are
  honored correctly ("Compiler flags" of
  http://fedoraproject.org/wiki/Packaging/Guidelines )
* Compilation flag "-O3" is not allowed for Fedora because this
  makes debugging difficult.
* Also "-fomit-frame-pointer" is forbidden
* And please consider to remove "-ffast-math" as this relaxes
  calculation precision and may cause debugging difficult.
* We now recommend %defattr(-,root,root,-)
* Please write the %files entry more verbosely so that we can grasp
  what files are installed easily.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.