[Bug 249236] Review Request: kde-style-domino - KDE style with a soft look

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kde-style-domino - KDE style with a soft look


https://bugzilla.redhat.com/show_bug.cgi?id=249236


thomas.moschny at gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thomas.moschny at gmx.de




------- Additional Comments From thomas.moschny at gmx.de  2008-01-24 05:09 EST -------
What's the status of this package?

(In reply to comment #13)
> It doesn't build on mock. rpmlint are Ok.

Which spec/srpm are you referring to?

The one made by Kelly or the the one made by  
http://liviopl.fedorapeople.org/domino.spec ?

> Some issues that should be fixed:
> - Put all .la file on a -devel package

.la files are special and needed for kde addon packages. This has been 
explained earlier. Same for .desktop here.

> - Use "3" suffix to kde-packages (if possible)

Don't think so, as this package is going to be approved for F-7 and F-8 only.

> - Build require /usr/lib/libkdecorations.la (kdebase-libs)
>    require /usr/include/kde/kcommondecoration.h (kdebase3-devel who require
> kdebase-libs, and kdelibs3-devel)

Should be "BuildRequires: kdebase-devel".

> - call ldconfig in %post & %postun

Not needed, as %{_libdir}/kde3 is not one of the dynamic linker's default 
paths.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.