[Bug 427162] Review Request: sagator - antivir/antispam gateway for smtp server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sagator - antivir/antispam gateway for smtp server


https://bugzilla.redhat.com/show_bug.cgi?id=427162


lemenkov at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From lemenkov at gmail.com  2008-01-24 11:54 EST -------
REVIEW:

[-] rpmlint is not silent however I don't think this is a blocker. See comments
above:

petro at localhost SPECS $ rpmlint ../RPMS/noarch/sagator-*
sagator.noarch: W: file-not-utf8 /usr/share/doc/sagator-1.0.0/test/pack/rtest.zip
sagator.noarch: W: spurious-executable-perm
/usr/share/doc/sagator-1.0.0/test/policytest
sagator.noarch: E: non-standard-gid /usr/share/sagator/etc vscan
sagator.noarch: E: non-standard-dir-perm /usr/share/sagator/etc 0750
sagator.noarch: W: spurious-executable-perm
/usr/share/doc/sagator-1.0.0/test/pattern
sagator.noarch: E: non-standard-gid /etc/sagator.conf vscan
sagator.noarch: E: non-readable /etc/sagator.conf 0640
sagator.noarch: E: non-standard-uid /var/spool/vscan/tmp vscan
sagator.noarch: E: non-standard-gid /var/spool/vscan/tmp vscan
sagator.noarch: E: non-standard-dir-perm /var/spool/vscan/tmp 01777
sagator.noarch: W: spurious-executable-perm /usr/share/doc/sagator-1.0.0/db/pgsql.sh
sagator.noarch: E: non-standard-uid /var/www/html/sagator vscan
sagator.noarch: E: non-standard-gid /var/www/html/sagator vscan
sagator.noarch: E: non-standard-dir-perm /var/www/html/sagator 0775
sagator.noarch: W: spurious-executable-perm
/usr/share/doc/sagator-1.0.0/test/bigtest
sagator.noarch: W: spurious-executable-perm /usr/share/doc/sagator-1.0.0/db/mysql.sh
sagator.noarch: W: spurious-executable-perm
/usr/share/doc/sagator-1.0.0/test/smtptest
sagator.noarch: W: spurious-executable-perm
/usr/share/doc/sagator-1.0.0/db/sqlite.sh
sagator.noarch: W: spurious-executable-perm
/usr/share/doc/sagator-1.0.0/test/mimeattach.py
sagator.noarch: E: non-standard-uid /var/spool/vscan/tmp/quarantine vscan
sagator.noarch: E: non-standard-gid /var/spool/vscan/tmp/quarantine vscan
sagator.noarch: E: non-standard-dir-perm /var/spool/vscan/tmp/quarantine 0770
sagator.noarch: W: doc-file-dependency
/usr/share/doc/sagator-1.0.0/test/mimeattach.py /usr/bin/python2
sagator.noarch: W: service-default-enabled /etc/init.d/sagator
sagator.noarch: W: service-default-enabled /etc/init.d/sagator
sagator.noarch: W: uncompressed-zip /usr/share/doc/sagator-1.0.0/test/pack/rtest.zip
sagator-webq.noarch: W: no-documentation

[+] The package named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format %{name}.spec.
[+] The package meets the Packaging Guidelines.
[+] The package licensed with a Fedora approved license and meet the Licensing
Guidelines.
[+] The License field in the package spec file matches the actual license.
[+] The source package includes the text of the license(s) in its own file in %doc.
[+] The spec file written in American English.
[+] The spec file for the package is legible.
[?] The sources used to build the package matches the upstream source. However
there is an error in source path in spec-file and there is more recent snapshot.
[+] The package successfully compile and build into binary rpms on at least one
supported architecture.
[+] All build dependencies are listed in BuildRequires.
[+] A package owns all directories that it creates.
[+] A package does not contain any duplicate files in the %files listing.
[+] Permissions on files are set properly instead of those described in the
above comments.
[+] Package has a %clean section.
[+] Package consistently use macros, as described in the macros section of
Packaging Guidelines.
[+] The package contains code, or permissable content.
[+] Packages does not own files or directories already owned by other packages.
      [+] The package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
[+] All filenames in rpm packages are valid UTF-8.

OK. You should fix the source path in the spec-file and it's APROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.