[Bug 226416] Merge Review: shadow-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: shadow-utils


https://bugzilla.redhat.com/show_bug.cgi?id=226416


limb at jcomserv.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From limb at jcomserv.net  2008-01-25 12:39 EST -------
rpmlint on srpm:

shadow-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 140, tab: line 66)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

Minor.

rpmlint on rpms:

shadow-utils.i386: E: non-readable /usr/sbin/userdel 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/userdel 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: non-readable /usr/sbin/groupdel 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupdel 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: non-readable /usr/sbin/groupmems 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupmems 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: setuid-binary /usr/bin/newgrp root 04755
The file is setuid, this may be dangerous, especially if this
file is setuid root.

shadow-utils.i386: E: non-standard-executable-perm /usr/bin/newgrp 04755
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: non-readable /usr/sbin/groupadd 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupadd 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: setuid-binary /usr/bin/chage root 04755
The file is setuid, this may be dangerous, especially if this
file is setuid root.

shadow-utils.i386: E: non-standard-executable-perm /usr/bin/chage 04755
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: non-readable /etc/default/useradd 0600
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-readable /usr/sbin/usermod 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/usermod 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: setuid-binary /usr/bin/gpasswd root 04755
The file is setuid, this may be dangerous, especially if this
file is setuid root.

shadow-utils.i386: E: non-standard-executable-perm /usr/bin/gpasswd 04755
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: E: non-readable /usr/sbin/useradd 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/useradd 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

shadow-utils.i386: W: file-not-utf8 /usr/share/doc/shadow-utils-4.1.0/HOWTO
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

shadow-utils.i386: E: non-readable /usr/sbin/groupmod 0750
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupmod 0750
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

The non-standard perms make sense to me for this package.  The file-not-utf8 for
th HOWTO is a simple fix, and worth doing.

License tag should be BSD and GPLv2+.

Otherwise, no additional blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.