[Bug 225673] Merge Review: cyrus-sasl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: cyrus-sasl


https://bugzilla.redhat.com/show_bug.cgi?id=225673


sconklin at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED




------- Additional Comments From sconklin at redhat.com  2008-01-25 18:07 EST -------
I just tagged and built cyrus-sasl-2.1.22-11.fc9

> rpmlint on srpm:
>
> cyrus-sasl.src: W: strange-permission make-no-dlcompatorsrp-tarball.sh 0755

> cyrus-sasl.src: W: strange-permission saslauthd.init 0755

> Probably acceptable.

I left these alone.

> rpmlint on rpms:
>
> cyrus-sasl.i386: E: executable-marked-as-config-file
> cyrus-sasl.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/saslauthd

Fix these, or explain in spec.

Fixed

> cyrus-sasl.i386: W: incoherent-init-script-name saslauthd
>
> Would correcting this break anything?

There are two reasons not to change this:
1. It will likely break something else, as it's been named this for a very long
time.
2. The name of the init script does accurately reflect the name of the daemon,
it just doesn't match the rpm name because the rom also includes libraries, etc.

I think this should remain, and haven't changed it.

> cyrus-sasl-debuginfo.i386: W: spurious-executable-perm
> cyrus-sasl-debuginfo.i386: W: spurious-executable-perm
> cyrus-sasl-debuginfo.i386: W: spurious-executable-perm

All Fixed

> cyrus-sasl-devel.i386: W: no-dependency-on cyrus-sasl
>
> Fix.

Fixed

> cyrus-sasl-gssapi.i386: W: no-documentation
> cyrus-sasl-ldap.i386: W: no-documentation
> cyrus-sasl-md5.i386: W: no-documentation
> cyrus-sasl-ntlm.i386: W: no-documentation
> cyrus-sasl-plain.i386: W: no-documentation
> cyrus-sasl-sql.i386: W: no-documentation

> Can probably ignore, but I'd rather see it fixed if there are docs that are
> broken out into similar units as the packages.

There's no documentation for these that can even be broken out of the upstream
source, so I didn't change anything for this.

> Source0: tag needs to include the url to the tarball included in the SRPM.  IF
> this is a modified version of an upstream tarball, provide a script that
> converts the upstream tarball into the one provided.

This is documented in the spec file. The link to upstream is provided, and the
script which does the conversion.

> The Guidelines forbid the inclusion of .la files, these should be removed.

All removed.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.