[Bug 226484] Merge Review: telnet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: telnet


https://bugzilla.redhat.com/show_bug.cgi?id=226484


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2008-01-25 19:03 EST -------
rpmlint not silent:

telnet.src:31: W: buildprereq-use ncurses-devel
telnet.src:331: W: macro-in-%changelog setup
telnet.src: W: mixed-use-of-spaces-and-tabs (spaces: line 79, tab: line 81)
telnet.src: W: patch-not-applied Patch9: telnet-0.17-env-5x.patch
telnet.src: W: patch-not-applied Patch17: telnet-0.17-linemode.patch
telnet.src: W: summary-ended-with-dot The client program for the telnet remote
login protocol.
telnet.src: W: no-url-tag

Buildroot is not among the preferred ones.

Where does the telnet-client.tar.gz archive come from?

And also how was generated:
telnet-client-cvs.patch

What is all the strange pie stuff?

I would suggest using -p in 
install -p -m644 %SOURCE3 ${RPM_BUILD_ROOT}/etc/xinetd.d/telnet

It would certainly be better to use %{_sysconfdir} instead of /etc.

I suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root)

Also -g is already in RPM_OPT_FLAGS?

is
export CC_FLAGS="$CC_FLAGS"
really useful since CC_FLAGS looks empty?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.