[Bug 426728] Review Request: glpi-data-injection - Plugin for importing data into GLPI

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 26 11:40:45 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glpi-data-injection - Plugin for importing data into GLPI


https://bugzilla.redhat.com/show_bug.cgi?id=426728





------- Additional Comments From johan at x-tnd.be  2008-01-26 06:40 EST -------
Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and RPMs.
+ source file are ok.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ BuildRequires are proper.
+ package installed properly.
+ Macro use appears rather consistent.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list