[Bug 427722] Review Request: xsettings-kde - XSettings Daemon for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xsettings-kde - XSettings Daemon for KDE


https://bugzilla.redhat.com/show_bug.cgi?id=427722


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From wolfy at nobugconsulting.ro  2008-01-26 19:43 EST -------
It's almost OK, but a couple of fixes are needed
- please settle with either $RPM_BUILD_ROOT or %{buildroot}; you are using each
version twice
- as far as I understand, upstream is Mandriva's svn; please add a comment
indicating the manner to replicate the source file that you have included (bonus
points for mentioning the exact version )
- your make line does not include the magic %{?_smp_mflags}
- the source tar includes COPYING, therefore the final rpm should contain it, too
- I assume that not using desktop-file-install is intentional ?


I've attached a modified spec which fixes points 1-3 above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.