[Bug 428000] Review Request: ocaml-dbus - OCaml library for using D-Bus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-dbus - OCaml library for using D-Bus


https://bugzilla.redhat.com/show_bug.cgi?id=428000


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-26 23:20 EST -------
I'm getting through now without problems.

This builds fine and rpmlint is silent.  The only difference I can see between
this package and the suggestions in the guidelines is that this doesn't call
"make byte" and "make opt", but then the supplied Makefile doesn't support those
targets.  I suppose this would only cause an issue on ppc64, which is excluded
anyway.

You have the same file included in both the main and -devel packages.  I don't
think it's a blocker, but normally there's no point in doing this.

Since you're excluding PPC64, don't forget to open a ticket describing the
reasons for that and have it block FE-ExcludeArch-ppc64.

* source files match upstream:
   900d4bf337891cf9f17cda9b8c269b832718e41b26239a81b46aa9f31f030bae  
   ocaml_dbus-0.03.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* specfile follows the ocaml packaging guidelines.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64, i386, ppc).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
  ocaml-dbus-0.03-2.fc9.x86_64.rpm
   dlldbus_stubs.so()(64bit)
   ocaml(DBus) = e11b402ab86e8d7fad43b48a7b50bf7e
   ocaml-dbus = 0.03-2.fc9
  =
   ocaml(List) = da1ce9168f0408ff26158af757456948
   ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57
   ocaml(Unix) = 9a46a8db115947409e54686ada118599
   ocaml(runtime) = 3.10.0

  ocaml-dbus-devel-0.03-2.fc9.x86_64.rpm
   ocaml-dbus-devel = 0.03-2.fc9
  =
   ocaml-dbus = 0.03-2.fc9

* %check is not present; no test suite upstream.  I've no clue how to test an 
   ocaml library.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
? no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.