[Bug 429086] Review Request: sonic-visualiser - A program for viewing and exploring audio data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sonic-visualiser - A program for viewing and exploring audio data


https://bugzilla.redhat.com/show_bug.cgi?id=429086





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-01-27 05:23 EST -------
Full review done:

MUST FIX:
---------

* License is wrong, should be GPLv2+
* Icon file should go to /usr/share/icons/hicolor/48x48/apps (per
  freedesktop.org icon standard), you should then also add a: "Requires
  hicolor-icon-theme" for directory ownership and icon cache update scriplets
  as listed here: 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
* rpmlint says:
  sonic-visualiser.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab:
line 11)

Other then that its fine.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.