[Bug 409511] Review Request: libmlx4 - Mellanox ConnectX InfiniBand HCA Userspace Driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmlx4 - Mellanox ConnectX InfiniBand HCA Userspace Driver


https://bugzilla.redhat.com/show_bug.cgi?id=409511





------- Additional Comments From rolandd at cisco.com  2008-01-27 17:47 EST -------
Thanks for the review!  A few comments/questions:

 > libmlx4.x86_64: W: conffile-without-noreplace-flag 
 >    /etc/libibverbs.d/mlx4.driver
 > If it's a config, you probably don't want an rpm update wiping out end-user
 > customization, so you should use %config(noreplace).  The difference is whether
 > rpm creates a .rpmnew file instead of moving the old version to .rpmsave.

the mlx4.driver file is not exactly a config file in the sense that there is
no useful change that a user can make right now; all it contains is a single
line that tells the libibverbs library to look for an "mlx4" plugin.  However
if I don't mark it as a conffile then rpmlint complains about non-config files
in /etc.  On the other hand, if some future version does introduce new info
in the mlx4.driver file, I think the best thing for a user would be to update
the file, so I left out the "noreplace" marking.

I don't have a strong opinion about the right thing here; although I did think
about this and make a semi-informed choice, just let me know if you want me to
change how the mlx4.driver file is handled, and I'll update my package.

 > Generally, the package containing the static library should be named "-static".
 >  However, if this would leave the -devel package empty, you can put the library
 > in the -devel package and have it provide -static.

Make sense, I will make the change and add the provides tag.

 > Since you install a shared library, you need to call ldconfig:
 >   %post -p /sbin/ldconfig
 >   %postun -p /sbin/ldconfig

The same issue came up when my libmthca package was reviewed (bug 169744).
The package does contain a .so file, but it is not something that is linked
to applications; rather, libibverbs uses dlopen() to load this plugin.  So
I don't think running ldconfig is necessary or desirable for this package.

I will prepare a package with the -devel-static -> -devel change and post it.
Let me know if my explanations for the other points make sense.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.