[Bug 411881] Package review: sim

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: sim


https://bugzilla.redhat.com/show_bug.cgi?id=411881





------- Additional Comments From pertusus at free.fr  2008-01-28 15:21 EST -------
Why the autoconf run? This shouldn't be needed? And the corresponding
patch shouldn't be applied. Also it seems to me that 
make -f admin/Makefile.common
and
make -C plugins/remote clean # what the hell...
are not needed (and certainly harmful).

xdg-open should be used instead of htmlview in the patch.
It should be a Requires.

Why isn't the gkrellm subpackage always built?

The desktop_file shouldn't be conditional, but always true.

%{buildroot} or $RPM_BUILD_ROOT should be used, not both.

for desktop-file-install, vendor should be fedora, and Application 
category is wrong.

Also no need for 
mkdir -p $RPM_BUILD_ROOT/%{_datadir}/applications
if you use the file in that directory...

In the rm commands, -r is in general not needed since these
are files. I would suggest also not using -f since this allows
to find when things have changed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.