[Bug 225786] Merge Review: gd
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jan 28 21:25:45 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: gd
https://bugzilla.redhat.com/show_bug.cgi?id=225786
bugzilla at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|devel |rawhide
pertusus at free.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |ASSIGNED
Resolution|NEXTRELEASE |
------- Additional Comments From pertusus at free.fr 2008-01-28 16:25 EST -------
I haven't seen any file under the GPL. (There is one which is more
bsd than mit, but it doesn't matter much).
I suggest adding NEWS to %doc.
Also I suggest adding INSTALL='install -p' to make install line
to keep timestamps.
I suggest removing the -f for rm such that it fails if files doesn't
exist anymore:
rm $RPM_BUILD_ROOT/%{_libdir}/libgd.la
rm $RPM_BUILD_ROOT/%{_libdir}/libgd.a
In case you didn't know, rpmlint says:
gd.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 16)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list