[Bug 226557] Merge Review: xfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: xfig


https://bugzilla.redhat.com/show_bug.cgi?id=226557


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
             Status|NEEDINFO                    |NEW
               Flag|needinfo?                   |




------- Additional Comments From pertusus at free.fr  2008-01-28 17:13 EST -------
rpmlint says:
xfig.i386: W: no-documentation
xfig.i386: W: obsolete-not-provided xfig-Xaw3d
xfig-plain.i386: W: no-documentation
xfig-common.i386: E: non-executable-script
/usr/share/xfig/Libraries/Maps/USA/assemble 0644
xfig-common.i386: E: non-executable-script
/usr/share/xfig/Libraries/Maps/Canada/assemble 0644

The xfig.i386: W: obsolete-not-provided xfig-Xaw3d should certainly
be fixed.

I think that the non-executable script should be ignored, otherwise
csh will become a dependency. Maybe a comment could be added (when 
doing chmods in %prep?).

Some timestamps could be kept, for example after the iconv call, 
there could be
  touch -r $i $i.UTF-8
But fixing all would require more work, not really that important.

I would have preferred to have virtual provides with parenthesis
like  %{name}(executable)

Otherwise it is very clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.