[Bug 429081] Review Request: perl-DateTime-Format-Oracle - Parse and format Oracle dates and timestamps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-Oracle - Parse and format Oracle dates and timestamps


https://bugzilla.redhat.com/show_bug.cgi?id=429081


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-29 01:38 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
672f1496bacf11660fa4001d7ef8cce2  DateTime-Format-Oracle-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/defaults...........ok
t/format_datetime....ok
t/parse_datetime.....ok
All tests successful.
Files=3, Tests=35,  1 wallclock secs ( 0.82 cusr +  0.05 csys =  0.87 CPU)
+ Package perl-DateTime-Format-Oracle-0.03-1.fc9 =>
  Provides: perl(DateTime::Format::Oracle) = 0.03
  Requires: perl(Carp) perl(Convert::NLS_DATE_FORMAT) perl(DateTime)
perl(DateTime::Format::Builder) perl(strict)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.