[Bug 430578] Review Request: xmlcopyeditor - A fast, free, validating XML editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlcopyeditor - A fast, free, validating XML editor


https://bugzilla.redhat.com/show_bug.cgi?id=430578





------- Additional Comments From marc at mwiriadi.id.au  2008-01-29 04:56 EST -------
- MUST: rpmlint must be run on every package. The output should be posted in the
review. (OK)
- MUST: The package must be named according to the Package Naming Guidelines. (OK)
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec (OK)
- MUST: The package must meet the Packaging Guidelines. (OK)
- MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines. (OK)
- MUST: The License field in the package spec file must match the actual
license. (OK)
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. (ok)
- MUST: The spec file must be written in American English. (OK)
- MUST: The spec file for the package MUST be legible.  (OK)
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. (OK)
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture. (OK)
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines; inclusion of
those as BuildRequires is optional. Apply common sense. (OK)
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. (OK)
- MUST: A package must not contain any duplicate files in the %files listing. (OK)
- MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. (OK)
- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). (OK)
- MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines. (OK)
- MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. (OK)
- MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. (OK)
- MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. (OK)


APPROVED

I won't put a formal Approval till someone more experienced has double checked
what I have done but as far as I'm concerned there is no problems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.