[Bug 430071] Review Request: igraph - Library for creating and manipulating graphs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: igraph - Library for creating and manipulating graphs


https://bugzilla.redhat.com/show_bug.cgi?id=430071


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-30 00:15 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM. 
- rpmlint is NOT silent for RPM.
igraph-devel.i386: W: wrong-file-end-of-line-encoding
/usr/share/doc/igraph-devel-0.4.5/simple/igraph_write_graph_pajek.out
igraph-devel.i386: W: wrong-file-end-of-line-encoding
/usr/share/doc/igraph-devel-0.4.5/simple/LINKS.NET

+ source files match upstream url
a2f462c3519eb1d49b9c5a4827358e3a  igraph-0.4.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ igraph.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package igraph-0.4.5-3.fc9 ->
  Provides: libigraph.so.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libigraph.so.0
libm.so.6 libm.so.6(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)
+ Package  igraph-devel-0.4.5-3.fc9 ->
  Requires: igraph = 0.4.5-3.fc9 libigraph.so.0 pkgconfig
+ Not a GUI App.

SHOULD:
   1)change %doc examples/simple to %doc/examples and remove .arch-ids from
examples also.
   This makes more sense for whats simple directory as its parent directory will
then examples.

   2)Good if you provide Makefile also in simple directory.

   3) You can either resolve rpmlint messages by using iconv on those 2 files in
%prep or let it be as its not problematic.


APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.