[Bug 430859] Review Request: netmonitor - The free linux network bandwidth monitor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netmonitor - The free linux network bandwidth monitor


https://bugzilla.redhat.com/show_bug.cgi?id=430859





------- Additional Comments From panemade at gmail.com  2008-01-30 05:34 EST -------
Suggestions:-
   Apply following patch which resolves
1) compiler flags not honored issue
2) remove unneeded "make install" call
3) remove unnecessary INSTALL file 

==============================================================================
 %prep
-%setup -q -n %{name}-0.4b
-./configure --libdir=%{_libdir}
+%setup -q -n %{name}-0.4b

 %build
-#nothing to build
+./configure --libdir=%{_libdir} --prefix=%{_prefix}
+%{__make} CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}

 %install
 rm -rf $RPM_BUILD_ROOT
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
-make install DESTDIR=%{buildroot}
-cp -p src/%{name} $RPM_BUILD_ROOT%{_bindir}
-cp -p src/%{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1
+install -p -m755 src/%{name} $RPM_BUILD_ROOT%{_bindir}
+install -p -m644 src/%{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1

 %clean
 rm -rf $RPM_BUILD_ROOT

 %files
 %defattr(-,root,root,-)
-%doc README INSTALL TODO COPYING NEWS AUTHORS ChangeLog
-%exclude /usr/local/bin/%{name}
-%exclude /usr/local/man/man1/%{name}.1
+%doc README TODO COPYING NEWS AUTHORS ChangeLog
 %{_mandir}/man1/%{name}.1.gz
 %{_bindir}/%{name}

=============================================================================

When I tried to create patch I got some encoding issue to include pl language
description to be included in patch so pasting here directly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.