[Bug 429445] Review Request: waf - A Python-based build system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: waf - A Python-based build system


https://bugzilla.redhat.com/show_bug.cgi?id=429445





------- Additional Comments From thomas.moschny at gmx.de  2008-01-30 06:02 EST -------
(In reply to comment #19)
> Hm, might put that back. On the other hand, it's currently not being
> referred to by any other files, so it's probably safe for now?

Yeah, but it's merely a matter of principle. Of course one has to look at 
rpmlint's complaints, but an empty file in the demo suite doesn't hurt.

> Probably would not affect the review, but Thomas, if you could pull the
> trunk file that fixes check_tool, we should probably ship with that patched
> in?

The attached patch (= trunk changeset of r2219) fixes the gnome demo. You 
could added that to the source rpm.

However, I don't think we want to add more patches for the demo suite. Better 
let's bug upstream to fix that in the next release. The testsuite ('waf 
check') also fails for 1.3.1 (but maybe I didn't run it properly).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.