[Bug 430070] Review Request: evolution-rss - Evolution RSS Reader Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-rss - Evolution RSS Reader Plugin


https://bugzilla.redhat.com/show_bug.cgi?id=430070


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp,
                   |                            |dwinship at redhat.com




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-01-30 12:59 EST -------
cc-ing Dan. This won't build with libsoup 2.4 (rawhide)
http://koji.fedoraproject.org/koji/taskinfo?taskID=381907

On dist-f8-updates-candidate, it surely builds.
http://koji.fedoraproject.org/koji/taskinfo?taskID=381997

>From quick glance at your spec file:
* Would you explain why this package should have
  "Requies: firefox"?
* Perhaps "Requires: dbus, dbus-glib" is redundant (and
  should be removed). rpmbuild checks the dependency for libraries
  and adds the dependency to rebuilt binary rpms, which
  should pull dbus, dbus-glib automatically
* "BuildRequires: gettext" is redundant if "BuildRequires:
  gettext-devel" is really needed.
* "BuildRequires: gcc-c++" is redundant (see the section
   "Exceptions" of
   http://fedoraproject.org/wiki/Packaging/Guidelines )
* "BuildRequires: dbus" is redundant. dbus-glib-devel
   requires dbus.
* Please try to use %configure macro
* GConf scriptlet is not right. Please refer to
  the section "GConf" of
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
* %_prefix/bin must be replaced with %_bindir.

By the way, now it seems your spec/srpm link seem 404 (not found)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.