[Bug 430978] Review Request: libsoup22 - Backward compatibility package for libsoup 2.2 API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libsoup22 - Backward compatibility package for libsoup 2.2 API


https://bugzilla.redhat.com/show_bug.cgi?id=430978





------- Additional Comments From notting at redhat.com  2008-01-30 21:38 EST -------
MUST Items:
 - Package meets naming and packaging guidelines - OK
 - Spec file matches base package name. - OK
 - Spec has consistant macro usage. - OK
 - Meets Packaging Guidelines. - OK
 - License  - ***

No version is ever listed in the source files. Ergo, the license is
any version of LGPL -> LGPLv2+.

 - License field in spec matches - See above
 - License file included in package  - OK
 - Spec in American English  - OK
 - Spec is legible.  - OK
 - Sources match upstream md5sum:
ab3b10b1c97de5abe38a748a3656da4c - OK
 - Package needs ExcludeArch - N/A
 - BuildRequires correct - OK
 - Spec handles locales/find_lang - N/A
 - Package is relocatable and has a reason to be. - N/A
 - Package has %defattr and permissions on files is good. - OK
 - Package has a correct %clean section. - OK
 - Package has correct buildroot - ***

Using one of the preferred buildroots is... preferred, such as:
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 - Package is code or permissible content. - OK
 - Doc subpackage needed/used. - N/A
 - Packages %doc files don't affect runtime. - OK
 - Headers/static libs in -devel subpackage. - OK
 - Spec has needed ldconfig in post and postun - OK
 - .pc files in -devel subpackage/requires pkgconfig - OK
 - .so files in -devel subpackage. - OK
 - -devel package Requires: %{name} = %{version}-%{release} - OK
 - .la files are removed. - OK
 - Package compiles and builds on at least one arch. - OK (tested x86_64)
 - Package has no duplicate files in %files. - OK
 - Package doesn't own any directories other packages own. - OK
 - Package owns all the directories it creates. - OK
 - No rpmlint output. ***
libsoup22.x86_64: E: explicit-lib-dependency libxml2 - See below.
libsoup22-devel.x86_64: W: no-documentation - ignorable
 - final provides and requires are sane: - ***

Requires: glib2 >= 2.6
Requires: gnutls
Requires: libxml2

All seem superfluous. gnutls and libxml2 are already picked up by normal library
requires, and the glib2 configure test is already looking for 2.12.x, if I'm
reading it right.

SHOULD Items:

 - Should build in mock. - tested x86_64
 - Should function as described. - did not try
 - Should have sane scriptlets.  - OK
 - Should have dist tag - OK
 - Should package latest version - OK

Please fix a) license tag b) buildroot c) requires. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.