[Bug 431013] Review Request: perl-CSS-Squish - Compact many CSS files into one big file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CSS-Squish -  Compact many CSS files into one big file


https://bugzilla.redhat.com/show_bug.cgi?id=431013


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-31 09:56 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d992129bf96368a504fe9c67b6d3e622  CSS-Squish-0.07.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
t/00-use......................ok
t/01-basic....................ok
t/02-edge-cases...............ok
t/03-skip-http................ok
t/04-recursion................ok
t/05-basic-loop-prevention....ok
t/06-server-relative-urls.....skipped
        all skipped: Functionality non-existant.  (and tests incomplete.)
t/07-basic-extra-roots........ok
t/99-pod-coverage.............ok
t/99-pod......................ok
All tests successful, 1 test skipped.
Files=10, Tests=15,  1 wallclock secs ( 0.58 cusr +  0.12 csys =  0.70 CPU)
+ Package  perl-CSS-Squish-0.07-1.fc9 ->
  Provides: perl(CSS::Squish) = 0.07
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(File::Spec) perl(Scalar::Util)
perl(URI) perl(URI::file) perl(strict) perl(warnings)

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.