[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)


https://bugzilla.redhat.com/show_bug.cgi?id=187243





------- Additional Comments From tibbs at math.uh.edu  2008-01-31 15:50 EST -------
So this is back in the pool.  Perhaps I'll find the time to look at it if nobody
beats me to it.  If the package in comment 34 is the one you'd like reviewed,
please say so or go ahead and drop another package.

However, some things I didn't see mentioned before.  One warning from
desktop-file-install during the package build:
+ desktop-file-install --vendor fedora --dir
/var/tmp/lazarus-0.9.24-1.fc9-root-mockbuild/usr/share/applications
lazarus/install/lazarus.desktop
/var/tmp/lazarus-0.9.24-1.fc9-root-mockbuild/usr/share/applications/fedora-lazarus.desktop:
warning: value "lazarus.png" for key "Icon" in group "Desktop Entry" is an icon
name with an extension, but there should be no extension as described in the
Icon Theme Specification if the value is not an absolute path

and come rpmlint complaints:
  lazarus.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10)
I'm not generally concerned about these.

  lazarus.src: W: invalid-license GPL, MPL
  lazarus.src: W: invalid-license modified LGPL
Please use proper License tags according to
http://fedoraproject.org/wiki/Licensing and
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines.  If the "modified
LGPL" in use doesn't fit any existing tags and something like "LGPLv2+ with
exceptions" isn't close enough then you will need to have the licensing experts
assign a new tag for you.

  lazarus.x86_64: E: non-executable-script 
   /usr/lib64/lazarus/components/lazreport/doc/cvs2cl.pl 0644
  lazarus.x86_64: E: non-executable-script 
   /usr/lib64/lazarus/examples/trayicon/createbundle.sh 0644
  lazarus.x86_64: E: non-executable-script 
   /usr/lib64/lazarus/components/lazreport/tools/localize.sh 0644
Are you sure these shouldn't be executable?  What will call them?

  lazarus.x86_64: E: non-executable-script 
   /usr/lib64/lazarus/tools/install/cross_unix/debian_crosswin32/postrm 0644
I thought that according to comments above that this would be going away.

  lazarus.x86_64: W: ldd-failed /usr/lib64/lazarus/tools/svn2revisioninc
I think this was covered in a discussion above about fpc output always being
static, and should be OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.